Skip to content

Fix BrickController - restoring MouldKing DI interface registration#237

Merged
vicocz merged 2 commits into
defaultfrom
copilot/fix-brickcontroller-core-build
Jul 5, 2026
Merged

Fix BrickController - restoring MouldKing DI interface registration#237
vicocz merged 2 commits into
defaultfrom
copilot/fix-brickcontroller-core-build

Conversation

Copilot AI commented Jul 5, 2026

Copy link
Copy Markdown

The BrickController Core Build job was failing in VendorBuilderTests because MouldKing devices had been switched to IMouldKingDeviceManager, but the Autofac registrations used by the tests did not expose that interface. This aligns the MouldKing constructor/registration path so the production container and test container resolve the same graph.

  • MouldKing DI contract

    • add IMouldKingDeviceManager with the GetAppId() contract used by MouldKing devices
    • implement the interface on MouldKingDeviceManager
  • Constructor dependency alignment

    • update MK3_8, MK4, MK5, MK6
    • update MKBaseByte and MKBaseNibble
    • all now depend on IMouldKingDeviceManager instead of the concrete manager type
  • Autofac registration fix

    • register MouldKingDeviceManager as IMouldKingDeviceManager in MouldKing vendor registration
    • mirror the same interface registration in VendorBuilderTests so the test container matches runtime DI behavior
  • Result

    • resolves the Autofac DependencyResolutionException seen in the core build job for MouldKing device resolution
builder.RegisterDeviceManager<MouldKingDeviceManager>()
    .As<IMouldKingDeviceManager>()
    .SingleInstance();

Copilot AI changed the title [WIP] Fix failing GitHub Actions job BrickController Core Build Fix BrickController Core build by restoring MouldKing DI interface registration Jul 5, 2026
Copilot AI requested a review from vicocz July 5, 2026 19:51
Copilot finished work on behalf of vicocz July 5, 2026 19:51
@vicocz vicocz marked this pull request as ready for review July 5, 2026 20:05
@vicocz vicocz changed the title Fix BrickController Core build by restoring MouldKing DI interface registration Fix BrickController - restoring MouldKing DI interface registration Jul 5, 2026
@vicocz vicocz merged commit 5fd13f3 into default Jul 5, 2026
5 checks passed
@vicocz vicocz deleted the copilot/fix-brickcontroller-core-build branch July 5, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants